Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 'length' parameters consistent #4083

Closed
clintongormley opened this issue Nov 4, 2013 · 0 comments
Closed

Make 'length' parameters consistent #4083

clintongormley opened this issue Nov 4, 2013 · 0 comments
Assignees
@markharwood
Labels
v1.0.0.RC1

Comments

@clintongormley
Copy link

  • flt, flt_field, fuzzy, and match queries use prefix_length
  • query_string query uses fuzzy_prefix_length
  • completion suggested uses min_length and prefix_length

But

  • mlt_field_query and mlt_query use min_word_len and max_word_len
  • completion suggester uses max_input_len
  • phrase and term suggesters use min_word_len and prefix_len

Change all length parameters to ..._length
@s1monw s1monw mentioned this issue Jan 2, 2014
Closed
@ghost ghost assigned markharwood Jan 2, 2014
brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
@markharwood @brusic
Standardized use of “*_length” for parameter names rather than “*_len”.
4eb7366 
Java Builder apis drop old “len” methods in favour of new “length”
Rest APIs support both old “len: and new “length” forms using new ParseField class to a) provide compiler-checked consistency between Builder and Parser classes and
b) a common means of handling deprecated syntax in the DSL.
Documentation and rest specs only document the new “*length” forms
Closes elastic#4083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markharwood markharwood

Labels
v1.0.0.RC1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clintongormley @markharwood